roachprod: pass --tenant-scope on cert gen from old binaries#98198
Closed
healthy-pod wants to merge 1 commit intocockroachdb:masterfrom
Closed
roachprod: pass --tenant-scope on cert gen from old binaries#98198healthy-pod wants to merge 1 commit intocockroachdb:masterfrom
--tenant-scope on cert gen from old binaries#98198healthy-pod wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Previously, TLS client certs were scoped to the system tenant by default. After cockroachdb#97585, they became valid for all tenants by default (unless `--tenant-scope` is passed). This caused the multitenant-upgrade roachtest to fail when certs are generated using the latest roachprod binary from an old cockroach binary. This change ensures that such certs are not scoped to the system tenant only by passing `--tenant-scope`. Release note: None Epic: none Closes cockroachdb#97016
Member
|
This change is |
knz
reviewed
Mar 8, 2023
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajstorm, @healthy-pod, @smg260, and @srosenberg)
pkg/roachprod/install/cluster_synced.go line 1233 at r1 (raw file):
rm -fr certs mkdir -p certs VERSION=$(%[1]s version | grep "Build Tag:" | sed -e 's/Build Tag:[[:space:]]*//' | cut -d- -f1)
VERSION=$(%[1]s version --build-tag)
VERSION=${VERSION::3}
if [[ $VERSION = v22 ]]; then
...This makes me think we might want to backport my change to v22.1 and v22.2 and call it a day. Do we still expect to publish v22.1 releases? what do you think?
Contributor
Author
Nice
My concerns are
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, TLS client certs were scoped to the system tenant by default. After #97585, they became valid for all tenants by default (unless
--tenant-scopeis pass).This caused the multitenant-upgrade roachtest to fail when certs are generated using the latest roachprod binary from an old cockroach binary.
This change ensures that such certs are not scoped to the system tenant only by passing
--tenant-scope.Release note: None
Epic: none
Closes #97016