storepool: consider nodes dead after no gossip#98101
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 6, 2023
Merged
storepool: consider nodes dead after no gossip#98101craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
andrewbaptist
approved these changes
Mar 6, 2023
31a216a to
416c51d
Compare
In cockroachdb#97532 we removed a check that would consider stores as dead if they hadn't gossiped their store descriptor within the last `server.time_until_store_dead` period. This patch updates adds back in the dead check that was removed, so that stores which have not updated their store descriptor in gossip, in the last `server.time_until_store_dead` are considered dead. This is a mostly redundant check with node liveness mirroring this behavior, however necessary in some tests. Resolves: cockroachdb#97794 Release note: None
416c51d to
2f8156c
Compare
Contributor
Author
|
bors r=andrewbaptist |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #97532 we removed a check that would consider stores as dead if they
hadn't gossiped their store descriptor within the last
server.time_until_store_deadperiod.This patch updates adds back in the dead check that was removed, so
that stores which have not updated their store descriptor in gossip, in
the last
server.time_until_store_deadare considered dead.This is a mostly redundant check with node liveness mirroring this
behavior, however necessary in some tests.
Resolves: #97794
Release note: None