roachtest: simplify name resolution in new restore roachtests#98087
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 6, 2023
Merged
roachtest: simplify name resolution in new restore roachtests#98087craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Previously, restore roachtest name resolution was a bit convoluted: it could either be observed by calling a field in the restoreSpec, but only if getRuntimeSpecs() had been called, or by manually constructing it before hand. This patch simplifies name resolution: the roachtest writer now simply calls initTestName() to set the name after restoreSpec initialization, and then gets the name via restoreSpec.testName. Epic: none Release note: None
4943163 to
10801f9
Compare
lidorcarmel
approved these changes
Mar 6, 2023
Contributor
lidorcarmel
left a comment
There was a problem hiding this comment.
makes sense and lgtm.
Collaborator
Author
|
Tftr! bors r=lidorcarmel |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, restore roachtest name resolution was a bit convoluted: it could either be observed by calling a field in the restoreSpec, but only if getRuntimeSpecs() had been called, or by manually constructing it before hand. This patch simplifies name resolution: the roachtest writer now simply calls initTestName() to set the name after restoreSpec initialization, and then gets the name via restoreSpec.testName.
Epic: none
Release note: None