upgrades: fix race condition inside TestUpgradeSchemaChangerElements#97898
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 2, 2023
Merged
Conversation
Previously, the test TestUpgradeSchemaChangerElements could fail intermittently due to improper atomic usage, where we didn't properly check and swap flag used to determine if we should check for a job. This could lead to a race condition where we read twice on a channel. To address this, this patch will ensure that this wait is properly only done once. Fixes: cockroachdb#97439 Release note: None
Member
|
This change is |
8006181 to
47353e4
Compare
chengxiong-ruan
approved these changes
Mar 2, 2023
Collaborator
Author
|
@chengxiong-ruan TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the test TestUpgradeSchemaChangerElements could fail intermittently due to improper atomic usage, where we didn't properly check and swap flag used to determine if we should check for a job. This could lead to a race condition where we read twice on a channel. To address this, this patch will ensure that this wait is properly only done once.
Fixes: #97439
Release note: None