execbuilder: de-flake a recently introduced test#97775
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 28, 2023
Merged
execbuilder: de-flake a recently introduced test#97775craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
I'm not able to reproduce the flake under stress, but for some reason it appears that the stats on a system table are collected even though we disable the auto stats collection. Those stats rarely show a different `estimated row count`, so this commit skips that line from the output of the EXPLAIN. This is acceptable given the goal of the test is ensuring that a secondary index is used for the scan. Release note: None
Member
|
This change is |
michae2
approved these changes
Feb 28, 2023
Collaborator
michae2
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @msirek)
Member
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not able to reproduce the flake under stress, but for some reason it appears that the stats on a system table are collected even though we disable the auto stats collection. Those stats rarely show a different
estimated row count, so this commit skips that line from the output of the EXPLAIN. This is acceptable given the goal of the test is ensuring that a secondary index is used for the scan.Fixes: #97771.
Release note: None