storage: fix BenchmarkMVCCExportToSST#97684
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 26, 2023
Merged
Conversation
Fix `BenchmarkMVCCExportToSST` to assert that the total number of range key spans within all range keys stacks is greater than or equal to the number of range keys added. Fix cockroachdb#96209. Release note: None.
Member
|
This change is |
Collaborator
Author
$ ./dev bench pkg/storage -f=BenchmarkMVCCExportToSST --ignore-cache --bench-time=1x --timeout 10m --test-args="-test.failfast"
$ bazel test --test_timeout=605 --test_arg -test.timeout=10m0s pkg/storage:all --nocache_test_results --test_arg -test.run=- --test_arg -test.bench=BenchmarkMVCCExportToSST --test_sharding_strategy=disabled --test_arg -test.benchtime=1x --crdb_test_off --test_arg -test.outputdir=/home/nickt/Development/go/src/github.com/cockroachdb/cockroach --sandbox_writable_path=/home/nickt/Development/go/src/github.com/cockroachdb/cockroach --test_arg -test.failfast --test_output errors
INFO: Invocation ID: 3187dfe3-0eb7-43f6-a55c-5baa32837d8d
INFO: Analyzed 3 targets (0 packages loaded, 0 targets configured).
INFO: Found 2 targets and 1 test target...
INFO: Elapsed time: 234.404s, Critical Path: 234.11s
INFO: 2 processes: 1 internal, 1 linux-sandbox.
INFO: Build completed successfully, 2 total actions
//pkg/storage:storage_test PASSED in 234.1s
INFO: Build completed successfully, 2 total actions |
Collaborator
Author
|
TFTR! bors r=erikgrinaker |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
BenchmarkMVCCExportToSSTto assert that the total number of range key spans within all range keys stacks is greater than or equal to the number of range keys added.Fix #96209.
Release note: None.
Epic: CRDB-20465.