server: initialize DBContext with correct instance ID#97467
Merged
craig[bot] merged 2 commits intomasterfrom Feb 23, 2023
Merged
server: initialize DBContext with correct instance ID#97467craig[bot] merged 2 commits intomasterfrom
craig[bot] merged 2 commits intomasterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Collaborator
Author
|
bors r=knz |
Contributor
|
|
Contributor
|
Is it possible to add an assert or test to prevent future regressions? |
Collaborator
Author
|
bors cancel |
Contributor
|
Canceled. |
Collaborator
Author
|
@j82w Good call. I'll see what happens if I add a few assertion failures in places where we expect to have a sql instance ID. |
Before this change the DBContext in a tenant would always have a zero'd SQLInstanceID. Note that for SQL pods not co-located on an KV-node, OptionalNodeID() should still return 0 and anything that requires a NodeID rather than an InstanceID _should_ be using that method. Informs: #96353 Epic: none Release note: None
part of #96353 Epic: None Release note: None
9a21db9 to
e49d44f
Compare
Collaborator
Author
|
bors r=knz |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change the DBContext in a tenant would always have a zero'd SQLInstanceID.
Note that for SQL pods not co-located on an KV-node, OptionalNodeID() should still return 0 and anything that requires a NodeID rather than an InstanceID should be using that method.
Informs: #96353
Epic: none
Release note: None