kvserver: increase cpu lb split threshold to 500ms#97113
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 21, 2023
Merged
kvserver: increase cpu lb split threshold to 500ms#97113craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This commit increases the default value of `kv.range_split.load_cpu_threshold` to `500ms` from the previous default value of `250ms`. Experiments detailed in cockroachdb#96869 showed moderate performance gains between `500ms` and `250ms`, without a significant downside on rebalancing. Resolves: cockroachdb#96869 Release note (ops change): The default value of `kv.range_split.load_cpu_threshold` is increased from `250ms` to `500ms`. This threshold declares the CPU per-second value above which a range will be split. The value was selected based on performance experiments.
4af46ff to
9bb2043
Compare
nvb
approved these changes
Feb 21, 2023
Contributor
nvb
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @kvoli)
Contributor
Author
|
bors r=nvanbenschoten |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit increases the default value of
kv.range_split.load_cpu_thresholdto500msfrom the previous default value of250ms. Experiments detailed in #96869 showed moderate performance gains between500msand250ms, without a significant downside on rebalancing.Resolves: #96869
Release note (ops change): The default value of
kv.range_split.load_cpu_thresholdis increased from250msto500ms. This threshold declares the CPU per-second value above which a range will be split. The value was selected based on performance experiments.