ui: add latency info to stmt pages#97082
Conversation
|
This change is |
ericharmeling
left a comment
There was a problem hiding this comment.
LGTM, just some tooltip nits!
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dongniwang, @kevin-v-ngo, and @maryliag)
pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx line 911 at r1 (raw file):
placement="bottom" style="tableTitle" content={<p>Maximum latency value of the {contentModifier}.</p>}
nit: suggestion
Suggestion:
The highest latency value in the sampled {contentModifier} executions with this fingerprint.pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx line 932 at r1 (raw file):
placement="bottom" style="tableTitle" content={<p>Minimum latency value of the {contentModifier}.</p>}
nit: suggestion
Suggestion:
The lowest latency value in the sampled {contentModifier} executions with this fingerprint.pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx line 953 at r1 (raw file):
placement="bottom" style="tableTitle" content={<p>The 50 Percentile for the {contentModifier}.</p>}
nit: suggestion
Suggestion:
The 50th latency percentile for {contentModifier} executions with this fingerprint.pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx line 974 at r1 (raw file):
placement="bottom" style="tableTitle" content={<p>The 90 Percentile for the {contentModifier}.</p>}
nit: suggestion
Suggestion:
The 90th latency percentile for {contentModifier} executions with this fingerprint.pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx line 995 at r1 (raw file):
placement="bottom" style="tableTitle" content={<p>The 99 Percentile for the {contentModifier}.</p>}
nit: suggestion
Suggestion:
The 99th latency percentile for {contentModifier} executions with this fingerprint.14c5740 to
edebfe3
Compare
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx line 911 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
nit: suggestion
All your suggestions are a lot better, thank you!
pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx line 932 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
nit: suggestion
Done
pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx line 953 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
nit: suggestion
Done
pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx line 974 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
nit: suggestion
Done
pkg/ui/workspaces/cluster-ui/src/statsTableUtil/statsTableUtil.tsx line 995 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
nit: suggestion
Done
edebfe3 to
28997a8
Compare
Part Of: cockroachdb#72954 Add p50, p90, p99, max and min latency to Statement table on SQL Activity page. Release note (ui change): Add columns p50, p90, p99, max and min latency for Statement table on SQL Activity page.
28997a8 to
e406d04
Compare
|
TFTR! |
|
Build failed (retrying...): |
|
Build succeeded: |
Part Of: #72954
Add p50, p90, p99, max and min latency to
Statement table on SQL Activity page.
Release note (ui change): Add columns p50, p90, p99, max and min latency for Statement table on SQL Activity page.