storage: never set a too-old format version#97066
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 14, 2023
Merged
storage: never set a too-old format version#97066craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
This change asserts that we never set a pebble FormatVersion that is older than the one minimum supported by our code. Benchmarks that set a lower value are updated (and BenchmarkTimeBoundIterate is reenabled). These benchmarks can fail when the code exercises a feature like range keys that is not supported by the older format. Fixes cockroachdb#97061 Release note: None Epic: none
98ae2db to
9d24366
Compare
This was referenced Feb 14, 2023
nicktrav
approved these changes
Feb 14, 2023
Collaborator
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @bananabrick and @sumeerbhola)
Member
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change asserts that we never set a pebble FormatVersion that is
older than the minimum supported by our code.
Benchmarks that set a lower value are updated (and
BenchmarkTimeBoundIterate is reenabled). These benchmarks can fail
when the code exercises a feature like range keys that is not
supported by the older format.
Fixes #97061
Release note: None
Epic: none