changefeedccl: skip testing queries that are too slow as regular SQL#96967
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 9, 2023
Merged
changefeedccl: skip testing queries that are too slow as regular SQL#96967craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
samiskin
approved these changes
Mar 9, 2023
| query = "SELECT array_to_string(IFNULL(array_agg(distinct rowid),'{}'),'|') FROM seed WHERE " + where | ||
| t.Log(query) | ||
| rows := s.DB.QueryRow(query) | ||
| timeoutCtx, cancel := context.WithTimeout(context.Background(), time.Second*2) |
Contributor
There was a problem hiding this comment.
Nit that doesn't really matter: This has a timeout of 2 seconds but the commit message says 1
TestChangefeedRandomExpressions was occasionally timing out when doing the regular SELECT query--it's tricky to get sqlsmith not to generate complex expressions that are likely to not be valid for changefeeds anyway, so this PR just skips predicates that take more than 2 seconds to process. Informs cockroachdb#96532. Release note: None
Contributor
Author
|
bors r=[samiskin] |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestChangefeedRandomExpressions was occasionally timing out when doing the regular SELECT query--it's tricky to get sqlsmith not to generate complex expressions that are likely to not be valid for changefeeds anyway, so this PR just skips predicates that take more than a second to process.
Informs #96532.
Release note: None