workload: support import parallelism for multi-tenant cluster#96904
Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom Feb 21, 2023
Merged
workload: support import parallelism for multi-tenant cluster#96904craig[bot] merged 3 commits intocockroachdb:masterfrom
craig[bot] merged 3 commits intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
adityamaru
approved these changes
Feb 15, 2023
Contributor
adityamaru
left a comment
There was a problem hiding this comment.
LGTM, i don't know if we have tests in workloadccl but in case you want to add a small unit test.
05ae185 to
414e65b
Compare
All nodes now produce entries in the sql_instances table, so we are able to use that table to get a node count even when running against a secondary tenant. I've kept the original query in place to support older clusters. Fixes cockroachdb#78968 Release note: None
Release note: None
I've run these under stress for a few hundred iterations and haven't encountered a problem. Release note: none
414e65b to
5f66471
Compare
Collaborator
Author
|
bors r=adityamaru |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All nodes now produce entries in the sql_instances table, so we are able to use that table to get a node count even when running against a secondary tenant.
I've kept the original query in place to support older clusters.
Fixes #78968
Release note: None