Skip to content

clusterversion: remove replication version gates#96786

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
erikgrinaker:repl-version-gates
Feb 13, 2023
Merged

clusterversion: remove replication version gates#96786
craig[bot] merged 2 commits intocockroachdb:masterfrom
erikgrinaker:repl-version-gates

Conversation

@erikgrinaker
Copy link
Copy Markdown
Contributor

clusterversion: remove AddSSTableTombstones version gate

Epic: none
Release note: None

clusterversion: remove GCHintInReplicaState cluster version

Also removes roachpb.SplitTrigger.WriteGCHint since we now always write GC hints.

Resolves #96760.

Epic: none
Release note: None

@erikgrinaker erikgrinaker requested a review from a team as a code owner February 8, 2023 10:04
@erikgrinaker erikgrinaker requested a review from a team February 8, 2023 10:04
@erikgrinaker erikgrinaker self-assigned this Feb 8, 2023
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Also removes `roachpb.SplitTrigger.WriteGCHint` since we now always
write GC hints.

Epic: none
Release note: None
Copy link
Copy Markdown
Contributor

@aliher1911 aliher1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@erikgrinaker
Copy link
Copy Markdown
Contributor Author

bors r+

@craig craig bot merged commit 18c5a38 into cockroachdb:master Feb 13, 2023
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 13, 2023

Build succeeded:

@erikgrinaker erikgrinaker deleted the repl-version-gates branch March 21, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replication: remove V22_2 gates and related logic/migrations/etc

3 participants