Skip to content

clusterversion: rename V22_2* gates to TODODelete_V22_2*#96754

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
celiala:mark-22.2-gates-ok-to-delete
Feb 8, 2023
Merged

clusterversion: rename V22_2* gates to TODODelete_V22_2*#96754
craig[bot] merged 1 commit intocockroachdb:masterfrom
celiala:mark-22.2-gates-ok-to-delete

Conversation

@celiala
Copy link
Copy Markdown
Collaborator

@celiala celiala commented Feb 7, 2023

Now that we've bumped minBinary to 22.2, 22.2 gates are now safe for deletion.

This commit renames V22_2 gates to TODODelete_V22_2*.

Actual gate deletion and related logic/migrations will be done async by teams.

Issue: #95530
Epic: CRDB-23572

Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Now that we've bumped minBinary to 22.2, 22.2 gates are now safe for
deletion.

This commit renames V22_2 gates to TODODelete_V22_2*.

Action gate deletion and related logic/migrations will be done async
by teams.

Issue: cockroachdb#95530
Epic: CRDB-23572

Release note: None
@celiala celiala force-pushed the mark-22.2-gates-ok-to-delete branch from 3d12310 to 2b730a0 Compare February 7, 2023 23:11
@celiala celiala marked this pull request as ready for review February 8, 2023 00:11
@celiala celiala requested a review from a team as a code owner February 8, 2023 00:11
@celiala celiala requested a review from a team February 8, 2023 00:11
@celiala celiala requested review from a team as code owners February 8, 2023 00:11
@celiala celiala requested a review from a team February 8, 2023 00:11
@celiala celiala requested review from a team as code owners February 8, 2023 00:11
@celiala celiala requested review from a team February 8, 2023 00:11
@celiala celiala requested a review from a team as a code owner February 8, 2023 00:11
@celiala celiala requested a review from a team February 8, 2023 00:11
@celiala celiala requested a review from a team as a code owner February 8, 2023 00:11
@celiala celiala requested review from DrewKimball, benbardin, herkolategan, jbowens, samiskin and srosenberg and removed request for a team, DrewKimball, benbardin and samiskin February 8, 2023 00:11
@celiala celiala requested review from a team, HonoreDB, RaduBerinde and dt and removed request for a team February 8, 2023 00:12
Copy link
Copy Markdown
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @dt, @herkolategan, @HonoreDB, @jbowens, and @srosenberg)

@celiala
Copy link
Copy Markdown
Collaborator Author

celiala commented Feb 8, 2023

TFTR!

bors r=RaduBerinde

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 8, 2023

Build succeeded:

@craig craig bot merged commit d4f63d7 into cockroachdb:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants