clusterversion: remove TODOPreV22_1#96701
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 7, 2023
Merged
Conversation
Member
|
This change is |
f78ceef to
ffcfff2
Compare
ffcfff2 to
33260f4
Compare
This change removes this constant and the obsolete code that uses it. Release note: None Epic: none
33260f4 to
16878ed
Compare
sumeerbhola
reviewed
Feb 7, 2023
Collaborator
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewed 2 of 10 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @celiala and @jayshrivastava)
RaduBerinde
commented
Feb 7, 2023
Member
Author
RaduBerinde
left a comment
There was a problem hiding this comment.
TFTR! I'll merge since the only non-storage changes are removal of two tiny dead code sections.
bors r+
Reviewable status:
celiala
approved these changes
Feb 7, 2023
Collaborator
celiala
left a comment
There was a problem hiding this comment.
Thank you!! LGTM from the release eng side
Contributor
|
CDC side LGTM! |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes this constant and the obsolete code that uses it.
Release note: None
Epic: None