sql: use descs.Txn for schemachanger.txn#96598
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 6, 2023
Merged
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
This commit is to use the new internal executor interface introduced by cockroachdb#93218 for `schemachanger.txn()`. informs cockroachdb#91004 Release Note: None
a121525 to
8e149bf
Compare
ajwerner
approved these changes
Feb 6, 2023
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Very nice. Thanks!
Can we get rid of descs.FromTxn? Seems close to going away by plumbing descs.Txn where needed. Leave that for a separate PR.
Collaborator
Author
|
TFTR!
I think so. bors r=ajwerner |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit includes just mechanical changes to use the new internal executor interface introduced by #93218 for
schemachanger.txn().informs #91004
Release Note: None