Skip to content

ci: get rid of failures in make-based CI#96027

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rickystewart:testing
Jan 27, 2023
Merged

ci: get rid of failures in make-based CI#96027
craig[bot] merged 1 commit intocockroachdb:masterfrom
rickystewart:testing

Conversation

@rickystewart
Copy link
Copy Markdown
Collaborator

@rickystewart rickystewart commented Jan 26, 2023 •
edited
Loading

  1. We don't post to GitHub from make-based CI jobs any more, and
    github-post doesn't build cleanly from make any more. I delete
    all the code related to github-post from run_json_test.
  2. Delete teamcity-check-genfiles.sh which doesn't serve a purpose now
    that vendor is gone.

Epic: none
Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jan 26, 2023

This change is Reviewable

@rickystewart rickystewart force-pushed the testing branch 6 times, most recently from 9abe3a0 to e90b506 Compare January 26, 2023 21:50
@rickystewart
ci: get rid of failures in make-based CI
71d4a3f 
1. We don't post to GitHub from `make`-based CI jobs any more, and
   `github-post` doesn't build cleanly from `make` any more. I delete
   all the code related to `github-post` from `run_json_test`.
2. Delete `teamcity-check-genfiles.sh` which doesn't serve a purpose now
   that `vendor` is gone.

Epic: none
Release note: None
@rickystewart rickystewart changed the title [DNM/WIP] ci: exercise lint failures ci: get rid of failures in make-based CI Jan 26, 2023
@rickystewart rickystewart marked this pull request as ready for review January 26, 2023 21:51
@rickystewart rickystewart requested a review from a team as a code owner January 26, 2023 21:51
healthy-pod
healthy-pod approved these changes Jan 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@healthy-pod healthy-pod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion that can be done here or separately: do we need to keep running make-based Optimizer tests, make-based Random Syntax tests, and make-based Compose tests? If not we can stop scheduling the nightlies, delete teamcity-opttest.sh, teamcity-compose.sh, and teamcity-random-syntax.sh. I think teamcity-test-deadlock.sh is not used and can be deleted too but I couldn't confirm. This leaves run_json_test with only one reason to exist which is lint in teamcity-check.sh after which we can delete the whole function.

@rickystewart
Copy link
Copy Markdown
Collaborator Author

rickystewart commented Jan 26, 2023

Suggestion that can be done here or separately: do we need to keep running make-based Optimizer tests, make-based Random Syntax tests, and make-based Compose tests?

These should not be running on master any more and indeed looking at the jobs they are not running on master any more and only most recently ran on Jan 6 when we pushed a new version of release-21.2.

If not we can stop scheduling the nightlies, delete teamcity-opttest.sh, teamcity-compose.sh, and teamcity-random-syntax.sh.

AFAICT the scripts can be deleted from master today with no impact.

I think teamcity-test-deadlock.sh is not used and can be deleted too but I couldn't confirm.

I agree this script doesn't seem to be used any more.

In a follow-up PR I'll look at cleaning out the build directory more.

@rickystewart
Copy link
Copy Markdown
Collaborator Author

rickystewart commented Jan 26, 2023

bors r=healthy-pod

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 26, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 27, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 27, 2023

Build succeeded:

@craig craig bot merged commit 0b49fa7 into cockroachdb:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@healthy-pod healthy-pod healthy-pod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rickystewart @cockroach-teamcity @healthy-pod