storage: add CommitNoSyncWait and SyncWait to Batch interface#95862
storage: add CommitNoSyncWait and SyncWait to Batch interface#95862craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
pkg/storage/pebble_batch.go line 559 at r1 (raw file):
// Once we do that, document on the storage.Batch interface the meaning of // an error returned from this method and the guarantees that callers have // or don't have after they receive and error from this method.
nit: an eror ...
pkg/storage/pebble_batch.go line 578 at r1 (raw file):
// Once we do that, document on the storage.Batch interface the meaning of // an error returned from this method and the guarantees that callers have // or don't have after they receive and error from this method.
ditto
d7fff41 to
c1705dc
Compare
c1705dc to
9ab50a2
Compare
Extracted from cockroachdb#94165. Picks up github.com/cockroachdb/pebble/pull/2117. Release note: None Epic: None
9ab50a2 to
efe12b8
Compare
nvb
left a comment
There was a problem hiding this comment.
TFTR!
bors r=sumeerbhola
Reviewable status:
pkg/storage/pebble_batch.go line 559 at r1 (raw file):
Previously, sumeerbhola wrote…
nit: an eror ...
Done.
pkg/storage/pebble_batch.go line 578 at r1 (raw file):
Previously, sumeerbhola wrote…
ditto
Done.
|
Build succeeded: |
Extracted from #94165.
Picks up cockroachdb/pebble/pull/2117.
Release note: None
Epic: None