colinfo: add missing type families into CanHaveCompositeKeyEncoding#95839
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 26, 2023
Merged
colinfo: add missing type families into CanHaveCompositeKeyEncoding#95839craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
yuzefovich
commented
Jan 25, 2023
Member
Author
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis)
pkg/sql/catalog/colinfo/column_type_properties.go line 92 at r1 (raw file):
case types.UnknownFamily, types.AnyFamily: return true
I don't really understand why Unknown and Any are marked as composite here, but perhaps it doesn't matter that much.
This commit adds several missing type families into `CanHaveCompositeKeyEncoding` method. Some of these type families are internal and, probably, don't need to be handled, but we recently introduced TSVector and TSQuery types which were incorrectly marked as being composite since they were not mentioned explicitly in the type family switch. This commit also makes it so that we panic in this method if we forget to include a newly-introduced type into this switch. Release note: None
0bfef90 to
62110c0
Compare
Member
Author
|
Thanks Jordan! @cockroachdb/sql-schema I'd appreciate if someone took a look at this too. |
Member
Author
|
Got an implicit LGTM from Andrew. bors r+ |
Contributor
|
Build succeeded: |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds several missing type families into
CanHaveCompositeKeyEncodingmethod. Some of these type families are internal and, probably, don't need to be handled, but we recently introduced TSVector and TSQuery types which were incorrectly marked as being composite since they were not mentioned explicitly in the type family switch. This commit also makes it so that we panic in this method if we forget to include a newly-introduced type into this switch.Fixes: #95680.
Release note: None