Skip to content

[DNM] KV pushdown bisect#95793

Closed
yuzefovich wants to merge 15 commits intocockroachdb:masterfrom
yuzefovich:kv-pushdown-bisect
Closed

[DNM] KV pushdown bisect#95793
yuzefovich wants to merge 15 commits intocockroachdb:masterfrom
yuzefovich:kv-pushdown-bisect

Conversation

@yuzefovich
Copy link
Copy Markdown
Member

No description provided.

Once we add the dependency on `coldata` package into `storage`, there
would be an import cycle in dependencies in tests of `coldata` via
`randgen` dependency. This commit removes that.

Release note: None
This commit introduces `NextKVer` interface which only consists of
a single method for returning KVs from somewhere. The interface is then
used by the `cFetcher`. Currently, there is only one implementation
(`row.KVFetcher`), but soon we'll introduce another one to push the
projections into the KV layer. This required moving
`MVCCDecodingStrategy` type into `storage` package as well.

Note that I chose to not introduce other methods that `cFetcher` is
calling on `row.KVFetcher` since they won't be necessary for the
pushdown work. Also since (at least currently) the `cFetcher` doesn't
use the `spanID` value, we omit it from the interface method signature
(it's only used by the lookup joins which aren't yet vectorized).

Additionally, this commit moves a single comment to the appropriate
place.

Release note: None
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@yuzefovich
Copy link
Copy Markdown
Member Author

This PR exposed a bug in the prototype #92294 from in which "great" results were obtained. Those results are invalid, more details are here.

@yuzefovich yuzefovich closed this Jan 25, 2023
@yuzefovich yuzefovich deleted the kv-pushdown-bisect branch January 25, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants