logictest: fix retry on query that returns a fleeting error#95714
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 24, 2023
Merged
logictest: fix retry on query that returns a fleeting error#95714craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
6dfe876 to
9267aaf
Compare
61e6eb0 to
5306c78
Compare
yuzefovich
approved these changes
Jan 24, 2023
Member
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach and @mgartner)
-- commits line 4 at r1:
nit: also fixes #95700
pkg/sql/logictest/logic.go line 3231 at r1 (raw file):
} } return false, fmt.Errorf("%s: %s\nexpected success, but found\n%s", pos, sql, formatErr(err))
nit: add a quick comment for why we're returning this error but still do Errorf above for error from stmt.Close.
Fixes: cockroachdb#95664 Release note: None Epic: CRDB-20535
Contributor
Author
|
TFTR! |
rytaft
approved these changes
Jan 24, 2023
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @cucaroach and @mgartner)
pkg/sql/logictest/testdata/logic_test/retry line 6 at r1 (raw file):
# Unit test for bug #95664, retry on a query producing an error should # try again and succeed if err doesn't happen again.
nice test!
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #95664
Release note: None
Epic: CRDB-20535