Skip to content

kvserver: separate loadstats cpu nanos to raft/req#95387

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
kvoli:230117.misc-cpu-setup
Jan 20, 2023
Merged

kvserver: separate loadstats cpu nanos to raft/req#95387
craig[bot] merged 1 commit intocockroachdb:masterfrom
kvoli:230117.misc-cpu-setup

Conversation

@kvoli
Copy link
Copy Markdown
Contributor

@kvoli kvoli commented Jan 17, 2023

Previously, loadstats tracked replica raft/request cpu nanos per second separately but returned both summed together in load.ReplicaLoadStats. This patch separates RaftCPUNanosPerSecond and
RequestCPUNanosPerSecond in the returned load.ReplicaLoadStats so that they may be used independently.

Informs #95380

Release note: None

Previously, loadstats tracked replica raft/request cpu nanos per second
separately but returned both summed together in `load.ReplicaLoadStats`.
This patch separates `RaftCPUNanosPerSecond` and
`RequestCPUNanosPerSecond` in the returned `load.ReplicaLoadStats` so
that they may be used independently.

Informs cockroachdb#95380

Release note: None
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@kvoli kvoli marked this pull request as ready for review January 17, 2023 20:20
@kvoli kvoli requested a review from a team as a code owner January 17, 2023 20:20
@kvoli kvoli requested a review from andrewbaptist January 17, 2023 20:20
@kvoli kvoli self-assigned this Jan 17, 2023
Copy link
Copy Markdown

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvoli
Copy link
Copy Markdown
Contributor Author

kvoli commented Jan 20, 2023

TYFTR!

bors r=andrewbaptist

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 20, 2023

Build failed (retrying...):

@craig craig bot merged commit 1b79102 into cockroachdb:master Jan 20, 2023
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 20, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants