sql: make pg_description aware of builtin function descriptions#95294
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jan 17, 2023
Merged
sql: make pg_description aware of builtin function descriptions#95294craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
55e4d6c to
93f9b44
Compare
2fb14ab to
6977d89
Compare
6977d89 to
31e18d1
Compare
5eb76f8 to
8ce5a10
Compare
Release note (bug fix): The `prokind` column of `pg_catalog.pg_proc` is now populated properly.
This also extends the completion rules to properly handle functions in multiple namespaces. Release note (bug fix): `pg_catalog.pg_description` and `pg_catalog.obj_description()` are now able to retrieve the descriptive help for built-in functions.
8ce5a10 to
bd2953b
Compare
rafiss
approved these changes
Jan 17, 2023
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
lgtm!
Reviewed 1 of 3 files at r1, 10 of 10 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @msirek)
msirek
approved these changes
Jan 17, 2023
Contributor
msirek
left a comment
There was a problem hiding this comment.
Reviewable status:
Contributor
Author
|
Thanks to both! bors r=rafiss,msirek |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic: CRDB-23454
Fixes #95292.
Needed for #88061.
First commit from #95289.
This also extends the completion rules to properly handle
functions in multiple namespaces.
Release note (bug fix):
pg_catalog.pg_descriptionandpg_catalog.obj_description()are now able to retrieve the descriptive help for built-in functions.