randgen: ensure template does not become stale#94840
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 7, 2023
Merged
randgen: ensure template does not become stale#94840craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
knz
reviewed
Jan 6, 2023
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @postamar)
pkg/sql/catalog/randgen/templates.go line 200 at r1 (raw file):
Version: 1, State: descpb.DescriptorState_PUBLIC, Privileges: catpb.NewCustomSuperuserPrivilegeDescriptor(
I am confused by this. Why is this needed?
in tables.go line 177, the privileges are being overwritten.
Author
|
It's needed to pass the test? It's nice to know that the hardcoded template hasn't rotted. |
knz
approved these changes
Jan 6, 2023
Contributor
|
thanks |
This commit adds a unit test that ensures that the hard-coded table template is not stale in the face of RunPostDeserializationChanges. Informs cockroachdb#94026. Release note: None
42552ad to
863ceba
Compare
Author
|
Thanks for the review! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a unit test that ensures that the hard-coded table template is not stale in the face of RunPostDeserializationChanges.
Informs #94026.
Release note: None