tenantcapabilities: introduce a decoder for tenant capabilities#94722
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 7, 2023
Merged
tenantcapabilities: introduce a decoder for tenant capabilities#94722craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
6 tasks
knz
approved these changes
Jan 5, 2023
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ecwall)
575741e to
5558cf7
Compare
This patch introduces a decoder, which takes raw KVs from the system.tenants table and decodes them into (TenantID, TenantCapability) pairs. This is currently unusued. In a future commit, we'll establish a rangefeed over the `system.tenants` table to maintain a cached view of the global capabilities state. This decoder will be used to parse the rangefeed output. Looking towards such a watcher component, the decoder is placed in the `tenantcapabilitieswatcher` package. References cockroachdb#94643 Epic: CRDB-18503 Release note: None
5558cf7 to
a57cf17
Compare
Collaborator
Author
|
Rebased on top of master now that the PR with the first commit landed. TFTR! bors r+ |
Contributor
|
Build failed: |
Collaborator
Author
|
flaked. bors r=knz |
Contributor
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: |
Collaborator
Author
|
bors retry |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces a decoder, which takes raw KVs from the
system.tenants table and decodes them into
(TenantID, TenantCapability) pairs.
This is currently unusued. In a future commit, we'll establish a
rangefeed over the
system.tenantstable to maintain a cached viewof the global capabilities state. This decoder will be used to parse the
rangefeed output. Looking towards such a watcher component, the decoder
is placed in the
tenantcapabilitieswatcherpackage.References #94643
Epic: CRDB-18503
Release note: None