scripts: dev generate before updating dependencies#94721
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 4, 2023
Merged
scripts: dev generate before updating dependencies#94721craig[bot] merged 1 commit intocockroachdb:masterfrom
dev generate before updating dependencies#94721craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
rickystewart
approved these changes
Jan 4, 2023
rickystewart
reviewed
Jan 4, 2023
scripts/bump-pebble.sh
Outdated
|
|
||
| # Pull in the Pebble module at the desired SHA. | ||
| pushd "$COCKROACH_DIR" | ||
| ./dev generate |
Collaborator
There was a problem hiding this comment.
Nit: ./dev generate go is probably sufficient and faster.
nicktrav
approved these changes
Jan 4, 2023
Collaborator
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jbowens)
See cockroachdb#94712 (review) Epic: None Release note: None
271b888 to
748e84a
Compare
Contributor
Author
|
tftrs! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #94712 (review)
Epic: None
Release note: None