sql: add user-facing error for invalid job type in job_payload_type builtin#94713
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 4, 2023
Merged
Conversation
Member
|
This change is |
28d90eb to
7fcda04
Compare
rharding6373
approved these changes
Jan 4, 2023
Collaborator
rharding6373
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
…uiltin Previously, the `job_payload_type` builtin would return an internal error if the payload could be unmarshalled, but the type could not be determined. This changes ensures the builtin returns an appropriate user-facing error in this case. Epic: none Fixes: cockroachdb#94680 Release note: None
7fcda04 to
ef5ae32
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sql: add user-facing error for invalid job type in job_payload_type builtin
Previously, the
job_payload_typebuiltin would return an internal errorif the payload could be unmarshalled, but the type could not be determined.
This changes ensures the builtin returns an appropriate user-facing error
in this case.
Epic: none
Fixes: #94680
Release note: None