workload: fix non-determinism in TPC-H data generation#94702
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 4, 2023
Merged
workload: fix non-determinism in TPC-H data generation#94702craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit fixes the non-determinism in the TPC-H data generation by using a local slice for the random permutation of indexes into randPartNames. It also fixes the permutation algorithm to use a modified Fisher–Yates shuffle. Fixes cockroachdb#93958 Release note: None
Member
|
This change is |
srosenberg
approved these changes
Jan 4, 2023
rytaft
commented
Jan 4, 2023
Collaborator
Author
rytaft
left a comment
There was a problem hiding this comment.
TFTR!
CI failure is an unrelated flake #94716
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @herkolategan)
Contributor
|
Build succeeded: |
This was referenced Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the non-determinism in the TPC-H data generation by using a local slice for the random permutation of indexes into
randPartNames. It also fixes the permutation algorithm to use a modified Fisher–Yates shuffle.Fixes #93958
Release note: None