sql: add optimizer_use_limit_ordering_for_streaming_group_by session setting#94672
Conversation
|
This change is |
DrewKimball
left a comment
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rharding6373)
| groupingCols opt.ColSet, | ||
| newOrdering props.OrderingChoice, | ||
| ) { | ||
| if !c.e.evalCtx.SessionData().OptimizerUseLimitOrderingForStreamingGroupBy { |
There was a problem hiding this comment.
nit: add an xform test with this setting disabled and an expect-not to verify this works
rharding6373
left a comment
There was a problem hiding this comment.
Reviewable status:
…setting Fixes cockroachdb#93410 This commit adds the `optimizer_use_limit_ordering_for_streaming_group_by` session setting that defaults to `true`. When `true`, an exploration rule which uses the ordering specified in a `SELECT ... GROUP BY ... ORDER BY ... LIMIT n;` statement as an interesting ordering to require from the input to the group-by expression, possibly eliminating a top-k operation. When `false`, the exploration rule is disabled. Release note: None
905b302 to
63d9aed
Compare
msirek
left a comment
There was a problem hiding this comment.
TFTRs!
bors r+
Reviewable status:
pkg/sql/opt/xform/groupby_funcs.go line 231 at r1 (raw file):
Previously, mgartner (Marcus Gartner) wrote…
nit: add an xform test with this setting disabled and an
expect-notto verify this works
Done
|
Build succeeded: |
Fixes #93410
This commit adds the
optimizer_use_limit_ordering_for_streaming_group_bysession setting that defaults totrue. Whentrue, an exploration rule which uses the ordering specified in aSELECT ... GROUP BY ... ORDER BY ... LIMIT n;statement as an interesting ordering to require from the input to the group-by expression, possibly eliminating a top-k operation. Whenfalse, the exploration rule is disabled.Release note: None