changefeedccl: Re-enable schema changes with CDC expressions#94653
changefeedccl: Re-enable schema changes with CDC expressions#94653miretskiy merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
|
@HonoreDB @yuzefovich -- only the top PR needs to be reviewed. |
yuzefovich
left a comment
There was a problem hiding this comment.
DistSQL changes LGTM, will defer to Aaron for approval.
Reviewed 8 of 11 files at r6, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @HonoreDB and @miretskiy)
pkg/sql/distsql_plan_changefeed.go line 198 at r6 (raw file):
cdcPlan.PlanCtx.usePlannerDescriptorsForLocalFlow = true p := cdcPlan.PlanCtx.planner releaseDescriptors := func() {
nit: maybe s/releaseDescriptors/finishedSetupFn/?
pkg/ccl/changefeedccl/changefeed_test.go line 7052 at r6 (raw file):
}, { // Alter and rename a column The changefeed expression does not
nit: missing period here and below.
all done. |
bc8e7d8 to
ce4d48d
Compare
|
@HonoreDB -- can you take a look? |
5e9a109 to
da12696
Compare
HonoreDB
left a comment
There was a problem hiding this comment.
Reviewed 1 of 15 files at r1, 44 of 44 files at r14, 16 of 16 files at r15, 22 of 22 files at r16, 21 of 21 files at r17, 16 of 16 files at r18, 7 of 7 files at r19, 14 of 16 files at r20.
Reviewable status:
pkg/ccl/changefeedccl/changefeedbase/options.go line 952 at r20 (raw file):
if s.m[OptFormat] == string(OptFormatParquet) { if isPredicateChangefeed { // Diff option is allowed when using predicate changefeeds with parquet format.
Why is parquet different?
Stop requiring `schema_change_policy=stop` when running changefeeds with predicates. Fixes cockroachdb#84767 Epic: CRDB-17161 Release note (enterprise change): Changefeed transformations (`CREATE CHANGEFEED ... AS SELECT ...`) no longer require `schema_change_policy=stop` option.
Stop requiring
schema_change_policy=stopwhen runningchangefeeds with predicates.
Fixes #84767
Epic: CRDB-17161
Release note (enterprise change): Changefeed transformations
(
CREATE CHANGEFEED ... AS SELECT ...) no longer requireschema_change_policy=stopoption.