changefeedccl: Cache evaluation state per family#94459
Merged
miretskiy merged 1 commit intocockroachdb:masterfrom Jan 11, 2023
Merged
changefeedccl: Cache evaluation state per family#94459miretskiy merged 1 commit intocockroachdb:masterfrom
miretskiy merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
Author
|
@HonoreDB only top CL should be reviewed; others are reviewed elsewhere. |
HonoreDB
approved these changes
Jan 5, 2023
Contributor
HonoreDB
left a comment
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, 11 of 11 files at r2, 17 of 17 files at r3, 16 of 16 files at r4, 11 of 11 files at r5, 1 of 2 files at r6, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @miretskiy)
50f71e3 to
f4e0060
Compare
Previous PRs (cockroachdb#93979) moved the logic to scope changefeed expressions to specific column family to the optimizer. This had a side effect, causing CDC expression evaluator to re-initialize its plan every time event for a different family was received. This PR fixes this problem by having evaluator cache per-family state. Epic: CRDB-17161 Release note: None
Contributor
Author
|
bors r+ |
Contributor
Author
|
bors r- |
Contributor
|
Canceled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PRs (#93979) moved
the logic to scope changefeed expressions to specific column family
to the optimizer.
This had a side effect, causing CDC expression evaluator
to re-initialize its plan every time event for a different family
was received. This PR fixes this problem by having evaluator
cache per-family state.
Epic: CRDB-17161
Release note: None