logictest: fix flakes from mixed version testing#94458
logictest: fix flakes from mixed version testing#94458craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
ZhouXing19
left a comment
There was a problem hiding this comment.
Thanks! 
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
pkg/sql/logictest/logictestbase/logictestbase.go line 479 at r1 (raw file):
NumNodes: 3, CockroachGoBootstrapVersion: "v22.2.1", BootstrapVersion: roachpb.Version{Major: 22, Minor: 2},
nit: I'm wondering why we need this BootstrapVersion field. Seems to me that it's used in logicTest.newCluster(), which I think should not be called when we're using a testserver
The main fix was to wait for each node to be reachable before beginning the upgrade process. This also includes a version bump that has better logging to make it easier to debug. Release note: None
10815c0 to
b4f40e4
Compare
rafiss
left a comment
There was a problem hiding this comment.
tftr!
bors r=ZhouXing19
Reviewable status:
pkg/sql/logictest/logictestbase/logictestbase.go line 479 at r1 (raw file):
Previously, ZhouXing19 (Jane Xing) wrote…
nit: I'm wondering why we need this
BootstrapVersionfield. Seems to me that it's used inlogicTest.newCluster(), which I think should not be called when we're using a testserver
nice catch, it's not needed
|
Build succeeded: |
fixes #92637
The main fix was to wait for each node to be reachable before beginning the upgrade process. This also includes a version bump that has better logging to make it easier to debug.
Release note: None