kvserver: attempt deflake rq multistore rebalance#94428
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 29, 2022
Merged
kvserver: attempt deflake rq multistore rebalance#94428craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Previously,`TestReplicateQueueRebalanceMultiStore` would calculate the cluster lease and range count to assert against that the cluster balanced. This was problematic as the number of ranges may reduce over the duration of the test, or an inconsistent snapshot of range count could be taken. This patch attempts to deflake the test by using the total number of ranges that is returned when calculating the replicas and leases per store, in order to avoid the above inconsistency. Informs: cockroachdb#92219 Release note: None
f559de0 to
05a7e96
Compare
shralex
approved these changes
Dec 29, 2022
Contributor
Author
|
TYFTR |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
TestReplicateQueueRebalanceMultiStorewould calculate thecluster lease and range count to assert against that the cluster
balanced. This was problematic as the number of ranges may reduce over
the duration of the test, or an inconsistent snapshot of range count
could be taken.
This patch attempts to deflake the test by using the total number of
ranges that is returned when calculating the replicas and leases per
store, in order to avoid the above inconsistency.
Stressing with the patch:
Informs: #92219
Release note: None