Skip to content

sql: implement the log_timezone session variable#94123

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
otan-cockroach:log_timezone
Dec 22, 2022
Merged

sql: implement the log_timezone session variable#94123
craig[bot] merged 1 commit intocockroachdb:masterfrom
otan-cockroach:log_timezone

Conversation

@otan
Copy link
Copy Markdown
Contributor

@otan otan commented Dec 22, 2022

Informs #84505

Release note (sql change): Add the log_timezone session variable, which is read only and always UTC.

Release note (sql change): Add the `log_timezone` session variable,
which is read only and always UTC.
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@otan otan requested review from a team and rafiss December 22, 2022 05:05
Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @otan)


pkg/sql/vars.go line 345 at r1 (raw file):

	// See https://www.postgresql.org/docs/15/datatype-datetime.html.
	// We always log in UTC.

i didn't realize that. nice

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Dec 22, 2022

bors r=rafiss

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 22, 2022

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 22, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants