Skip to content

ui: degrade gracefully when regions aren't known#93985

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
matthewtodd:tenant-regions-undefined
Dec 21, 2022
Merged

ui: degrade gracefully when regions aren't known#93985
craig[bot] merged 1 commit intocockroachdb:masterfrom
matthewtodd:tenant-regions-undefined

Conversation

@matthewtodd
Copy link
Copy Markdown

@matthewtodd matthewtodd commented Dec 20, 2022

Part of #89949

Previously, when a tenant SQL instance had spun down (leaving us no way to remember which region it had been in), the SQL Activity pages would claim that statements and transactions had occurred in an "undefined" region.

This change moves from saying "undefined" to saying nothing at all, a slightly nicer user experience.

This broader problem of losing the region mapping has been described in #93268; we'll begin addressing it shortly.

Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Dec 20, 2022

This change is Reviewable

@matthewtodd
Copy link
Copy Markdown
Author

matthewtodd commented Dec 20, 2022

Here are some screenshots from before this fix. Note the "undefined"s and the trailing commas.

Screen Shot 2022-12-19 at 7 32 28 PM

Screen Shot 2022-12-19 at 7 32 36 PM

Screen Shot 2022-12-19 at 7 32 46 PM

Screen Shot 2022-12-19 at 7 32 57 PM

@matthewtodd
Copy link
Copy Markdown
Author

matthewtodd commented Dec 20, 2022 •
edited
Loading

Bazel Extended CI failures are unrelated, fallout from #93754, fixed in #94005.

[19:50:50][Bench //pkg/sql/opt/partialidx:partialidx_test] --- FAIL: BenchmarkImplicator
[19:50:50][Bench //pkg/sql/opt/partialidx:partialidx_test]     implicator_test.go:284: unexpected error while building filters: invalid syntax @5
[19:50:50][Bench //pkg/sql/opt/partialidx:partialidx_test] FAIL
[19:50:50][Bench //pkg/sql/opt/partialidx:partialidx_test] I221220 19:50:50.475685 1 (gostd) testmain.go:80  [-] 1  Test //pkg/sql/opt/partialidx:partialidx_test exited with error code 1
[19:50:51][Bench //pkg/sql/opt/partialidx:partialidx_test] Process exited with code 1

@matthewtodd matthewtodd requested a review from a team December 20, 2022 20:16
@matthewtodd matthewtodd marked this pull request as ready for review December 20, 2022 20:16
@matthewtodd matthewtodd requested a review from a team December 20, 2022 20:16
ui: degrade gracefully when regions aren't known
9157553 
Part of #89949

Previously, when a tenant SQL instance had spun down (leaving us no way
to remember which region it had been in), the SQL Activity pages would
claim that statements and transactions had occurred in an "undefined"
region.

This change moves from saying "undefined" to saying nothing at all, a
slightly nicer user experience.

This broader problem of losing the region mapping has been described
in #93268; we'll begin addressing it shortly.

Release note: None
maryliag
maryliag reviewed Dec 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any way to remove the value so there is no , on the column, without any values after the , ?
Screen Shot 2022-12-21 at 11.18.29 AM.png

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @matthewtodd)

matthewtodd
matthewtodd commented Dec 21, 2022
View reviewed changes
Copy link
Copy Markdown
Author

@matthewtodd matthewtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Sorry I wasn't clear. That's what this PR does, remove the comma. (The screenshots are of the Before Times.)

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @matthewtodd)

maryliag
maryliag approved these changes Dec 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool!
:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @matthewtodd)

@matthewtodd
Copy link
Copy Markdown
Author

matthewtodd commented Dec 21, 2022

Thanks, @maryliag!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 21, 2022

Build succeeded:

@craig craig bot merged commit 8ae6026 into cockroachdb:master Dec 21, 2022
@matthewtodd matthewtodd deleted the tenant-regions-undefined branch December 21, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maryliag maryliag maryliag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewtodd @cockroach-teamcity @maryliag