sql: add indnullsnotdistinct column to pg_catalog.pg_index#93933
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 20, 2022
Merged
sql: add indnullsnotdistinct column to pg_catalog.pg_index#93933craig[bot] merged 1 commit intocockroachdb:masterfrom
indnullsnotdistinct column to pg_catalog.pg_index#93933craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
rafiss
approved these changes
Dec 19, 2022
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
lgtm, once CI is passing
rafiss
reviewed
Dec 19, 2022
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @e-mbrown)
pkg/sql/pg_catalog.go line 1918 at r1 (raw file):
tree.NewDInt(tree.DInt(indnatts)), // indnatts tree.MakeDBool(tree.DBool(index.IsUnique())), // indisunique tree.DBoolFalse, //indnullsnotdistinct
nit: add a space after //
This commit `indnullsnotdistinct` column to pg_index. Since we do not support `NULLS [ NOT ] DISTINCT` on `CREATE INDEX` the column is also false. Release note: None
Contributor
Author
|
TFTR! bors r=rafiss |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic: CRDB-23454
Fixes: #92583
This commit
indnullsnotdistinctcolumn to pg_index. Since we do not supportNULLS [ NOT ] DISTINCTonCREATE INDEXthe column is also false.Release note: None