multitenant: check query rows result in admin function tests#93225
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 8, 2022
ecwall:multitenant_test_check_result
Merged
multitenant: check query rows result in admin function tests#93225craig[bot] merged 1 commit intocockroachdb:masterfrom ecwall:multitenant_test_check_result
craig[bot] merged 1 commit intocockroachdb:masterfrom
ecwall:multitenant_test_check_result
Conversation
Member
|
This change is |
ecwall
commented
Dec 7, 2022
| desc: "ALTER TABLE x EXPERIMENTAL_RELOCATE LEASE", | ||
| query: "ALTER TABLE t EXPERIMENTAL_RELOCATE LEASE SELECT 1, 1;", | ||
| expectedErrorMessage: errorutil.UnsupportedWithMultiTenancyMessage, | ||
| desc: "ALTER RANGE x RELOCATE NONVOTERS", |
Contributor
Author
There was a problem hiding this comment.
Also adds NONVOTERS version of VOTERS tests.
ecwall
commented
Dec 7, 2022
| query: "ALTER RANGE (SELECT min(range_id) FROM [SHOW RANGES FROM TABLE t]) RELOCATE VOTERS FROM 1 TO 1;", | ||
| expectedSecondaryErrorMessage: errorutil.UnsupportedWithMultiTenancyMessage, | ||
| }, | ||
| // TODO(ewall): Set up test to avoid "trying to add a voter to a store that already has a VOTER_FULL" error. |
Contributor
Author
There was a problem hiding this comment.
Some tests require additional setup that I will address when working on adding the Class to the related KV AdminRequest.
knz
approved these changes
Dec 8, 2022
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @arulajmani and @rafiss)
Informs CRDB-16746 Some admin functions return error rows in the response instead of an error itself. Update related tests to check these rows. Release note: None
Contributor
Author
|
bors r=knz |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Informs CRDB-16746
Some admin functions return error rows in the response instead of an error itself. Update related tests to check these rows.
Release note: None