Skip to content

[prototype] *: replication admission control #93102

Closed
irfansharif wants to merge 2 commits intocockroachdb:masterfrom
irfansharif:221205.repl-ac-sender
Closed

[prototype] *: replication admission control #93102
irfansharif wants to merge 2 commits intocockroachdb:masterfrom
irfansharif:221205.repl-ac-sender

Conversation

@irfansharif
Copy link
Copy Markdown
Contributor

@irfansharif irfansharif commented Dec 6, 2022

  • Deduct from quota pools post-proposal.
  • Plumb AC info per raft entry to receiver store.
  • Define integration point on the IOGrantCoordinator where logical token
    consumption informs the right quota pool.
  • Wire up the return path for quota, from the receiver all the way
    back to the sender.
    • Wire it up to the remote-store case.
    • Wire it up to the local-store case.
  • Segment work queue internals (logical vs. physical tokens).

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@irfansharif irfansharif force-pushed the 221205.repl-ac-sender branch 3 times, most recently from 831b14f to b153b97 Compare December 11, 2022 06:59
@irfansharif irfansharif changed the title [prototype] *: sender-side replication admission control [prototype] *: replication admission control Dec 11, 2022
@irfansharif irfansharif force-pushed the 221205.repl-ac-sender branch from b153b97 to 1d4f79b Compare December 12, 2022 22:49
@irfansharif irfansharif force-pushed the 221205.repl-ac-sender branch 3 times, most recently from 7232b0c to f4281a6 Compare December 28, 2022 16:50
@irfansharif irfansharif force-pushed the 221205.repl-ac-sender branch 20 times, most recently from 6545f19 to e7ef101 Compare December 30, 2022 16:33
@irfansharif irfansharif force-pushed the 221205.repl-ac-sender branch 6 times, most recently from 09321be to 73766ae Compare January 11, 2023 05:35
@irfansharif irfansharif force-pushed the 221205.repl-ac-sender branch 15 times, most recently from c811d40 to a3108c9 Compare January 16, 2023 19:32
- [x] Deduct from quota pools post-proposal.
- [x] Plumb AC info per raft entry to receiver store.
- [x] Define integration point on the IOGrantCoordinator where logical token
      consumption informs the right quota pool.
- [x] Wire up the return path for quota, from the receiver all the way
      back to the sender.
  - [x] Wire it up to the remote-store case.
  - [x] Wire it up to the local-store case.
- [x] Segment work queue internals (logical vs. physical tokens).

Release note: None
@irfansharif
Copy link
Copy Markdown
Contributor Author

#95563 is now further ahead code-wise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants