Skip to content

opt: update GenerateLookupJoinsWithVirtualCols comment#93042

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
mgartner:update-join-comment
Dec 5, 2022
Merged

opt: update GenerateLookupJoinsWithVirtualCols comment#93042
craig[bot] merged 1 commit intocockroachdb:masterfrom
mgartner:update-join-comment

Conversation

@mgartner
Copy link
Copy Markdown
Contributor

@mgartner mgartner commented Dec 5, 2022

Epic: None

Release note: None

@mgartner mgartner requested a review from yuzefovich December 5, 2022 15:41
@mgartner mgartner requested a review from a team as a code owner December 5, 2022 15:41
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@mgartner
Copy link
Copy Markdown
Contributor Author

mgartner commented Dec 5, 2022

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 5, 2022

Build succeeded:

@craig craig bot merged commit 969e6aa into cockroachdb:master Dec 5, 2022
@mgartner mgartner deleted the update-join-comment branch December 5, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants