ui: fix link for index from insights#92953
Conversation
|
This change is |
fe78266 to
553fa40
Compare
553fa40 to
35b996d
Compare
THardy98
left a comment
There was a problem hiding this comment.
just a quick question
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
pkg/ui/workspaces/cluster-ui/src/insightsTable/insightsTable.tsx line 333 at r1 (raw file):
title: insightsTableTitles.details(), cell: (item: InsightRecommendation) => descriptionCell(item, showQuery, disableStmtLink, hideAction),
why do we add hideAction here?
35b996d to
1045cee
Compare
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/insightsTable/insightsTable.tsx line 333 at r1 (raw file):
Previously, THardy98 (Thomas Hardy) wrote…
why do we add
hideActionhere?
this is the flag for "isCockroachCloud". I can rename to make it more clear
1045cee to
a72d2ce
Compare
Previously, the link to index details on the drop index insights was using the URL format used by DB Console only. This commit updates to use the correct format when loading from CC Console. Fix cockroachdb#92944 Release note (bug fix): Fix link to index details on drop index insights on CC Console.
a72d2ce to
700649c
Compare
|
TFTR! |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 700649c to blathers/backport-release-22.2-92953: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Previously, the link to index details on the
drop index insights was using the URL format used by DB Console only. This commit updates to use the correct format when loading from CC Console.
Fix #92944
Release note (bug fix): Fix link to index details on drop index insights on CC Console.