Skip to content

logictest: add couple more virtual lookup join tests#92937

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:virtual-lookup-join-test
Dec 3, 2022
Merged

logictest: add couple more virtual lookup join tests#92937
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:virtual-lookup-join-test

Conversation

@yuzefovich
Copy link
Copy Markdown
Member

This commit adds a couple more queries that use left semi and left anti virtual lookup joins as well as the execbuilder ones. Additionally, it replaces tabs with spaces in the tests added in the previous commit.

Epic: None

Release note: None

This commit adds a couple more queries that use left semi and left anti
virtual lookup joins as well as the execbuilder ones. Additionally, it
replaces tabs with spaces in the tests added in the previous commit.

Epic: None

Release note: None
@yuzefovich yuzefovich requested review from a team and rytaft December 2, 2022 18:16
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@yuzefovich
Copy link
Copy Markdown
Member Author

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 2, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 2, 2022

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 2, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 3, 2022

Build succeeded:

@craig craig bot merged commit 9c21578 into cockroachdb:master Dec 3, 2022
@yuzefovich yuzefovich deleted the virtual-lookup-join-test branch December 3, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants