clisqlshell: fix a panic on tab key#92934
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 2, 2022
Merged
Conversation
This patch ensures that there's no visible panic if the user presses "tab" and there's no completion available. Release note: None
Member
|
This change is |
rail
approved these changes
Dec 2, 2022
Member
rail
left a comment
There was a problem hiding this comment.
Worked perfectly fine! Thank you!
Contributor
Author
|
thanks! bors r=rail |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed: |
andyyang890
approved these changes
Dec 2, 2022
Collaborator
andyyang890
left a comment
There was a problem hiding this comment.
Doesn't panic anymore! 💯
Member
|
bors retry |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92935.
Epic: CRDB-22182
This patch ensures that there's no visible panic if the user presses "tab" and there's no completion available.
NB: no unit tests here - the test coverage will be delivered by #87606.