Skip to content

rttanalysis: skip test which doesn't work due to tracing limitations#92929

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/skip-hasura-rttanalysis-bench
Dec 2, 2022
Merged

rttanalysis: skip test which doesn't work due to tracing limitations#92929
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/skip-hasura-rttanalysis-bench

Conversation

@ajwerner
Copy link
Copy Markdown
Contributor

@ajwerner ajwerner commented Dec 2, 2022

This test ends up not seeing all the round trips because the trace is way too large. Given that, we get flakes sometimes. See the referenced issue (#88885).

Fixes #92770

Release note: None

This test ends up not seeing all the round trips because the trace is way too
large. Given that, we get flakes sometimes. See the referenced issue (cockroachdb#88885).

Fixes cockroachdb#92770

Release note: None
@ajwerner ajwerner requested review from a team and rafiss December 2, 2022 17:39
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this.

@ajwerner
Copy link
Copy Markdown
Contributor Author

ajwerner commented Dec 2, 2022

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 2, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 2, 2022

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 2, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 2, 2022

Build succeeded:

@craig craig bot merged commit 865ad56 into cockroachdb:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bench: flake in rttanalysis/BenchmarkORMQueries/hasura_column_descriptions

3 participants