sqlstats: record idle latency for transactions#92695
sqlstats: record idle latency for transactions#92695craig[bot] merged 1 commit intocockroachdb:masterfrom matthewtodd:idle_lat-txn
Conversation
|
This change is |
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @matthewtodd)
-- commits line 8 at r1:
should you also add this info to the node_transaction_statistics?
matthewtodd
left a comment
There was a problem hiding this comment.
Reviewable status:
Previously, maryliag (Marylia Gutierrez) wrote…
should you also add this info to the node_transaction_statistics?
Yes! Was planning to do that in a separate PR.
|
GitHub CI lint error is unrelated, fixed here. |
maryliag
left a comment
There was a problem hiding this comment.
Nice work!
Reviewed all commit messages.
Reviewable status:
Previously, matthewtodd (Matthew Todd) wrote…
Yes! Was planning to do that in a separate PR.
Sounds good!
|
Thank you! bors r+ |
|
Build succeeded: |
Part of #86667
Follows #91098
Release note (sql change): A new NumericStat, idleLat, was introduced to the statistics column of crdb_internal.transaction_statistics, reporting the time spent waiting for the client to send statements while holding a transaction open.