Skip to content

importer: use 1GiB max-sql-memory in a test#92678

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:import-monitor
Nov 29, 2022
Merged

importer: use 1GiB max-sql-memory in a test#92678
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:import-monitor

Conversation

@yuzefovich
Copy link
Copy Markdown
Member

Fixes: #92225.

Release note: None

@yuzefovich yuzefovich requested review from a team and adityamaru November 29, 2022 17:54
Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, seems like #91828 is a similar problem. i'll try this fix on that test too.

@yuzefovich
Copy link
Copy Markdown
Member Author

Hm, I wonder do we care enough to figure out why these two tests started flaking? It might be as simple as having better memory accounting in the import, or elsewhere in the system. Probably it's not worth the effort though.

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 29, 2022

Build succeeded:

@craig craig bot merged commit edc6fda into cockroachdb:master Nov 29, 2022
@yuzefovich yuzefovich deleted the import-monitor branch November 29, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql/importer: TestImportDefaultWithResume failed

2 participants