Skip to content

server_test: make TestClusterVersionUpgrade error more informative#92624

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
andyyang890:version_test_err
Nov 29, 2022
Merged

server_test: make TestClusterVersionUpgrade error more informative#92624
craig[bot] merged 1 commit intocockroachdb:masterfrom
andyyang890:version_test_err

Conversation

@andyyang890
Copy link
Copy Markdown
Collaborator

@andyyang890 andyyang890 commented Nov 28, 2022

This patch changes the error returned by TestClusterVersionUpgrade
when auto upgrade does not successfully complete to provide the
current version of the cluster instead of the old version.

Epic: None

Release note: None

This patch changes the error returned by TestClusterVersionUpgrade
when auto upgrade does not successfully complete to provide the
current version of the cluster instead of the old version.

Release note: None
@andyyang890 andyyang890 requested review from a team and renatolabs November 28, 2022 22:31
@andyyang890 andyyang890 requested a review from a team as a code owner November 28, 2022 22:31
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown

@renatolabs renatolabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@andyyang890
Copy link
Copy Markdown
Collaborator Author

bors r=renatolabs

@craig craig bot merged commit edc6fda into cockroachdb:master Nov 29, 2022
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 29, 2022

Build succeeded:

@andyyang890 andyyang890 deleted the version_test_err branch November 29, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants