Skip to content

server: include time units in app protos comments#92602

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
xinhaoz:comment-units
Nov 29, 2022
Merged

server: include time units in app protos comments#92602
craig[bot] merged 1 commit intocockroachdb:masterfrom
xinhaoz:comment-units

Conversation

@xinhaoz
Copy link
Copy Markdown
Contributor

@xinhaoz xinhaoz commented Nov 28, 2022

Closes #89976

This commit includes the unit of time in the comments of fields in app_stats protos where the unit of time was not specified.

Release note: None

@xinhaoz xinhaoz requested a review from a team November 28, 2022 19:03
@xinhaoz
Copy link
Copy Markdown
Contributor Author

xinhaoz commented Nov 28, 2022

@lnhsingh We want to document these units in https://www.cockroachlabs.com/docs/stable/crdb-internal.html.
Is there anything I should put in Release notes? Was unsure since there are no changes affecting behaviour in this PR but we'd like to document these units.

Closes cockroachdb#89976

This commit includes the unit of time in the comments of fields
in app_stats protos where the unit of time was not specified.

Release note: None
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@xinhaoz
Copy link
Copy Markdown
Contributor Author

xinhaoz commented Nov 29, 2022

Created docs issue: https://cockroachlabs.atlassian.net/browse/DOC-6259
bors r+

@craig craig bot merged commit edc6fda into cockroachdb:master Nov 29, 2022
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 29, 2022

Build succeeded:

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Nov 29, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 297b669 to blathers/backport-release-22.2-92602: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@xinhaoz xinhaoz deleted the comment-units branch December 6, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add units of time to protos

3 participants