ui: add 99.9th and 99.99th SQL latency charts#92591
ui: add 99.9th and 99.99th SQL latency charts#92591craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit introduces the charts for: `Service Latency: SQL Statements, 99.99th percentile` and `Service Latency: SQL Statements, 99.9th percentile` on Metrics page under SQL view. Fixes cockroachdb#74247 Release note (ui change): Added charts `Service Latency: SQL Statements, 99.9th percentile` and `Service Latency: SQL Statements, 99.99th percentile` to Metrics page, under SQL view.
|
This change is |
j82w
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @maryliag)
-- commits line 7 at r1:
Is it possible to have all of them in a single graph to make it easier to compare p99, p99.9, and p99.99? Having them in 3 separate graphs makes it kind of hard to compare the different percentiles. The different percentiles could have different color/shapes for the lines to make them distinguishable.
|
replying here because reviewable is not working atm |
j82w
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/sql.tsx line 217 at r1 (raw file):
tooltip={ <div> Over the last minute, this node executed 99.99% of SQL statements
Shouldn't this be 5 minutes? When hovering over the graph it jumps by 5 minute intervals.
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/sql.tsx line 217 at r1 (raw file):
Previously, j82w wrote…
Shouldn't this be 5 minutes? When hovering over the graph it jumps by 5 minute intervals.
I do see data every minute. This is the same tooltip used on all other charts, so I kept the same
|
TFTR! |
I can't seem to reply on Reviewable, but the interval changes based on the time range that is selected. |
|
Build failed (retrying...): |
|
Build succeeded: |
This commit introduces the charts for:
Service Latency: SQL Statements, 99.99th percentileandService Latency: SQL Statements, 99.9th percentileon Metrics page under SQL view.Fixes #74247
Release note (ui change): Added charts
Service Latency: SQL Statements, 99.9th percentileandService Latency: SQL Statements, 99.99th percentileto Metrics page, under SQL view.