Skip to content

scripts: improve pprof-loop.sh#92462

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
tbg:pprof-loop-v2
Nov 30, 2022
Merged

scripts: improve pprof-loop.sh#92462
craig[bot] merged 1 commit intocockroachdb:masterfrom
tbg:pprof-loop-v2

Conversation

@tbg
Copy link
Copy Markdown
Member

@tbg tbg commented Nov 24, 2022

Now it also works with the runtime trace endpoint (worked before but
printed concerning-looking errors) and with non-blocking endpoints
(cumulative profiles such as heap or mutex), for which it previously
busy-looped.

Epic: None
Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@tbg tbg marked this pull request as ready for review November 24, 2022 21:38
@tbg tbg requested a review from andrewbaptist November 24, 2022 21:38
Now it also works with the runtime trace endpoint (worked before but
printed concerning-looking errors) and with non-blocking endpoints
(cumulative profiles such as heap or mutex), for which it previously
busy-looped.

Epic: None
Release note: None
@tbg
Copy link
Copy Markdown
Member Author

tbg commented Nov 29, 2022

bors r=andrewbaptist
TFTR!

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 30, 2022

Build succeeded:

@craig craig bot merged commit b21fd88 into cockroachdb:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants