sql: remove Txn() from JobExecContext#92320
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Nov 23, 2022
Merged
Conversation
Member
|
This change is |
stevendanna
commented
Nov 22, 2022
Comment on lines
105
to
107
Collaborator
Author
There was a problem hiding this comment.
@cockroachdb/cdc-prs This bit is worth looking at.
Contributor
There was a problem hiding this comment.
Thanks for the heads up. I think this is fine since we cache the result anyway, and we just need consistent results while validating, not ones specific to the transaction.
Collaborator
Author
There was a problem hiding this comment.
Cool. And, I believe that in the context this was being called, that context would have been nil all of the time anyway. So hopefully this is a noop.
This appears to always be nil. As a method it doesn't really even make sense, since it is unclear would such a transaction commit. Release note: None
This removes Txn() from JobExecContext. This method would always return a nil context, making it a bit error prone to actually use in jobs. Release note: None
b2c206b to
d640759
Compare
adityamaru
approved these changes
Nov 22, 2022
Contributor
adityamaru
left a comment
There was a problem hiding this comment.
C2C and backup changes LGTM, but would be nice to get a cdc stamp too.
Collaborator
Author
|
bors r=adityamaru |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes Txn() from JobExecContext. This method would always
return a nil txn, making it a bit error prone to actually use in
jobs.
Epic: None
Release note: None